feat: Configurable geoip data file and data field path #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
changed the title
This commit adds the option to configure the geoip database file path and the data field to use. The existing defaults are preserved by setting default values for the new options. This has been tested against the maxmind geolite2 database, using `country.iso_code` and `continent.code` field paths. Signed-off-by: Jimmi Dyson <[email protected]>
jimmidyson
force-pushed
the
flexible-geoip-fields
branch
from
44789b7
to
8c9cd01
Compare
jimmidyson
changed the title
|
Hm, looks like we also need to check terratest run |
Signed-off-by: Yury Tsarev <[email protected]>
|
@jimmidyson @k0da i've reproduced the terratest failure locally and disable parallelism for the basic example test in 5db8eb8 As everything is green, I am merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the option to configure the geoip database file path
and the data field to use. The existing defaults are preserved by setting
default values for the new options.
This has been tested against the maxmind geolite2 database, using
country.iso_codeandcontinent.codefield paths.